crystal-coverage icon indicating copy to clipboard operation
crystal-coverage copied to clipboard

Published 20 hours ago • verified publisher icon anykeyh

Support crystal 1.0.0

Open erdnaxeli opened this issue 4 years ago • 4 comments

Hi,

In order to support crystal 1 you need to set the supported crystal version in shards.yml to ">=0.3X.0, <2" (by default it assume "<1"). You also need to use ameba from crystal-ameba/ameba.

erdnaxeli avatar Apr 07 '21 19:04 erdnaxeli

Hi @erdnaxeli!

I opened a PR that will fix this. Please take a look: https://github.com/anykeyh/crystal-coverage/pull/18

lbguilherme avatar Aug 21 '21 11:08 lbguilherme

You PR does not fix the constraint on crystal <1 neither the ameba dependency :)

erdnaxeli avatar Aug 23 '21 08:08 erdnaxeli

  • https://github.com/veelenga/ameba redirects to https://github.com/crystal-ameba/ameba, so the two are exactly the same and there is no visible difference for the user. The legacy name is supported.
  • shard.yml is not specifying a Crystal version, so by default shards install won't check and it will just work as the actual code compiles fine with Crystal 1+ now.

That said, I updated the PR with both points. Thanks!

lbguilherme avatar Aug 23 '21 12:08 lbguilherme

shard.yml is not specifying a Crystal version, so by default shards install won't check

IIRC no specifying a crystal version means "< 1.0" (https://crystal-lang.org/2020/08/20/preparing-our-shards-for-crystal-1.0.html).

erdnaxeli avatar Aug 23 '21 12:08 erdnaxeli