hugo-embed-pdf-shortcode icon indicating copy to clipboard operation
hugo-embed-pdf-shortcode copied to clipboard

Published 20 hours ago • verified publisher icon anvithks

fix URL and load pdf.js

Open RoneoOrg opened this issue 3 years ago • 1 comments

Hopefully fixes https://github.com/anvithks/hugo-embed-pdf-shortcode/issues/18 I tested both on localhost and deployed. I'm not familiar with Hugo's baseUrl settings, but this PR may at least improve things for a few users

Related https://github.com/anvithks/hugo-embed-pdf-shortcode/issues/26

RoneoOrg avatar Sep 30 '22 08:09 RoneoOrg

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 30 '22 08:09 sonarqubecloud[bot]

Changed the source of PDF.js to CDN delivery. This may be added to the documentation in case anyone wants to include pdf.js library via source.

anvithks avatar Mar 15 '23 10:03 anvithks

@RoneoOrg May be we can add this to the documentation or add a comment to the file in the appropriate locations indicating the usage. Would you be able to do that? Let me know.

anvithks avatar Mar 16 '23 08:03 anvithks

@RoneoOrg May be we can add this to the documentation or add a comment to the file in the appropriate locations indicating the usage. Would you be able to do that? Let me know.

I won't be available for that in the near future, sorry

RoneoOrg avatar Mar 16 '23 10:03 RoneoOrg

@RoneoOrg No worries. I can do it. I will close this PR though, if that's alright.

anvithks avatar Mar 16 '23 14:03 anvithks

Closing as this now added as a documentation.

anvithks avatar Mar 17 '23 06:03 anvithks