github-readme-stats
github-readme-stats copied to clipboard
Add `card_width` variable to the repository card #3368
I added the card_width and card_height parameters to the renderRepoCard function, allowing users to specify the card's width and height when calling the function. If these arguments are not provided, it falls back to default values. Issue Number#2900
@airwakz is attempting to deploy a commit to the github readme stats Team on Vercel.
A member of the Team first needs to authorize it.
@rickstaa here is thep pr please review it
@
@qwerty541 check this please
@rickstaa check it out
@airwakz Although I like your enthusiasm for implementing this feature request. Let's take a step back and clarify what was asked in https://github.com/anuraghazra/github-readme-stats/issues/2900 😅. In this issue, the problem was that @razonyang wanted the ability to set the card width and height of the pin card. For this to be implemented:
- First pull request: First, the
card_widthargument that is already present for the stats and language cards needs to be implemented for the pin card. You can use the code of the stats and language card to see how you can do this. - Second pull request: a new
card_heightargument must be added. This code will be similar to that of thecard_widthpull request.
For this, you don't need to touch the code of the language and stats cards. Although another feature request is open for these cards, I assigned @anmolchhabra21 to this (see https://github.com/anuraghazra/github-readme-stats/issues/3159). If you have any questions, feel free to comment below 😄.
i will make changes tomorrow as I have a college tomorrow .
i have made changes as per review @rickstaa
Codecov Report
All modified lines are covered by tests :white_check_mark:
Comparison is base (
365dfb7) 98.40% compared to head (c311a75) 98.40%. Report is 10 commits behind head on master.
:exclamation: Current head c311a75 differs from pull request most recent head 4147062. Consider uploading reports for the commit 4147062 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #3359 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 26 26
Lines 6002 6015 +13
Branches 534 539 +5
=======================================
+ Hits 5906 5919 +13
Misses 93 93
Partials 3 3
| Files | Coverage Δ | |
|---|---|---|
| api/pin.js | 97.91% <100.00%> (+0.04%) |
:arrow_up: |
| api/top-langs.js | 100.00% <100.00%> (ø) |
|
| src/cards/repo-card.js | 100.00% <100.00%> (ø) |
|
| src/cards/stats-card.js | 95.41% <100.00%> (ø) |
|
| src/cards/top-languages-card.js | 99.77% <100.00%> (+<0.01%) |
:arrow_up: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request will solve #3368.
i will add a documentation now
@rickstaa i think i made the changes and the proper dicumentation in code is alerdy provided by you
@rickstaa i think i made the changes and the proper dicumentation in code is alerdy provided by you
Like I said in my previous commit, you added the documentation to the wrong section. The documentation should be added to the repo card section (i.e. https://github.com/anuraghazra/github-readme-stats?tab=readme-ov-file#repo-card-exclusive-options). If you could do that, it would be great.
@rickstaa i make the changes in the documentation as requested by uh
@rickstaa i make the changes in the documentation as requested by uh
@airwakz, unfortunately, the documentation still needs to be corrected. You should only add the parameter you added card_width to the https://github.com/anuraghazra/github-readme-stats?tab=readme-ov-file#repo-card-exclusive-options section. Now you have added also the common parameters.
I will change it now
Any plans to merge this?