github-readme-stats
github-readme-stats copied to clipboard
fix(stats-fetcher): user's overall commits
- precise overall public commits (formerly exaggerated or decreased)
- precise overall private commits (formerly only the recent year) 1+2. precise overall commits including private commits
| current | my fork |
|---|---|
context: https://github.com/anuraghazra/github-readme-stats/issues/564#issuecomment-1083765940 The search API is entirely unreliable and we should never use it. Though using such a traversal could potentially cause rate limits, we should still get rid of using the search API. Why? Almost all Linux kernel contributors could never use this project as you have already seen above. It is absolutely unacceptable, isn't it? If we need to avoid being rate limited, we should consider using a database to cache users' commits in the past years.
Even I and @anuraghazra are affected:
| current | my fork |
|---|---|
If you want to check if you are affected, my deployment is https://github-readme-stats-rongronggg9.vercel.app/api
Close #518 Close #564 Close #1061 Close #1234 Close #1515
May influence #1260, #1455
@Rongronggg9 is attempting to deploy a commit to the github readme stats Team on Vercel.
A member of the Team first needs to authorize it.
@anuraghazra Does this look alright to merge now?
Shouldn't this be marked as bug and get a higher priority for merge?
Shouldn't this be marked as bug and get a higher priority for merge?
Although this PR is correct and makes the stats' card more correct, it will break the Public Vercel instance since it costs a lot more GraphQL points (see https://docs.github.com/en/graphql/overview/resource-limitations and https://github.com/anuraghazra/github-readme-stats/issues/1471). We therefore cannot merge this PR into the main branch. This feature will likely be included in the new GitHub action when it is released (see https://github.com/anuraghazra/github-readme-stats/issues/2179).
@Rongronggg9 @rickstaa may I ask you to fix conflicts here? I would really like to merge this PR to my fork master branch.
I've rebased the PR. However, due to #2100 which introduced mistaken GraphQL objects in the test suite, it cannot pass the tests. I will open another PR to fix this before I can force-push the rebased commits.
I've rebased the PR. However, due to #2100 which introduced mistaken GraphQL objects in the test suite, it cannot pass the tests. I will open another PR to fix this before I can force-push the rebased commits.
Well spotted. I merged your PR 👍🏻 !
I've squashed and rebased the PR @mathbunnyru
Thanks @Rongronggg9 ❤️
Codecov Report
Patch coverage: 91.04% and project coverage change: +0.06 :tada:
Comparison is base (
688f4e4) 97.35% compared to head (248be7c) 97.41%.
Additional details and impacted files
@@ Coverage Diff @@
## master #1691 +/- ##
==========================================
+ Coverage 97.35% 97.41% +0.06%
==========================================
Files 24 24
Lines 4310 4341 +31
Branches 393 394 +1
==========================================
+ Hits 4196 4229 +33
+ Misses 112 110 -2
Partials 2 2
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/fetchers/stats-fetcher.js | 94.46% <91.04%> (+1.34%) |
:arrow_up: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.