feat: Add support for gists

[qoomon]

trafficstars

This time I've tested everything is working :-) (shame on me for #6)

This PR will add support for gist stargazers e.g. https://stars.medv.io/qoomon/gist:5dfcdf8eec66a051ecd85625518cfd13.svg

• render.js
  • add gist support
• api.js
  • move rateLimit in graphQL queries (render.js) to api.js by reading limits from response header (recommended way by GitHub API docs)
  • replace r2 package with node-fetch package
• svg.js
  • refactor parameter to array of Date objects instead of epoch timestamp

[antonmedv]

Please deploy your version, so I can test my self

[qoomon]

Where should I deploy? Or just anywhere?

[antonmedv]

Just anywhere

[qoomon]

feel free to test http://ec2-3-72-47-194.eu-central-1.compute.amazonaws.com

[antonmedv]

Looks stuck at http://ec2-3-72-47-194.eu-central-1.compute.amazonaws.com/

[antonmedv]

Also I don't like hot a title for gists are shown .

[antonmedv]

Maybe we should have a separate url for gists? gist.stars.medv.io?

[qoomon]

You have used a wrong url pattern you need to use it like this <baseUrl>/<owner>/gist:<gistHash> e.g. http://ec2-3-72-47-194.eu-central-1.compute.amazonaws.com/qoomon/gist:5dfcdf8eec66a051ecd85625518cfd13

[antonmedv]

This is my point. This is very unintuitive what this sort support gists as well. So we can somehow highlight this in ui. Or maybe deploy at a separate url and name it Gist Sparklines?

[qoomon]

Or what about following convention?

• <baseUrl>/<owner>/<repoName>
• <baseUrl>/gist/<owner>/<gistHash>
• or back to the initial idea <baseUrl>/gist:<owner>/<gistHash>

I thinks repos(files and directories repos) and gist (file only repos) are so alike that is seems odd to have two deployments for that

[qoomon]

At least every thing is now working as expected, I fixed all issues.

[qoomon]

I've deployed a version with the initial url pattern <baseUrl>/gist:<owner>/<gistHash>

see http://ec2-3-72-47-194.eu-central-1.compute.amazonaws.com/gist:qoomon/5dfcdf8eec66a051ecd85625518cfd13

I think this is the most appealing variant

[antonmedv]

Super! Now it looks more cool.

One more thing. Lets get name of the gist from GraphQL api.

And use it here:

How difficult it will be to implement?

[qoomon]

Unfortunately it would be a complete refactoring. The header always shows the name of the first file (even if there a multiple files in one gist) And just an extra note /<firstFileName> is not guaranteed to be unique for a user.

[antonmedv]

I mean we can still use sha1, but only display name in the title. This will require saving gist names locally?

[qoomon]

I'd suggest that we release this version first, and then we add the gist display name later.

This will require saving gist names locally?

Yes that would be one option. Another option would be to call fetch('https://api.github.com/gists/<gistHash>') and resolve name on the fly

[qoomon]

I've implemented the gist display name, see http://ec2-3-72-47-194.eu-central-1.compute.amazonaws.com/gist:qoomon/5dfcdf8eec66a051ecd85625518cfd13

[qoomon]

WDYT?

[qoomon]

@antonmedv can we merge it so I can stop my instance again?

[antonmedv]

Will try to take a look tonight and deploy.

[qoomon]

@antonmedv do you still need the server? I'd like to shut it down.

[antonmedv]

No, you can shut it down.

[qoomon]

cool, looking forward to the merge and release

[qoomon]

@antonmedv can you estimate when you will merge this feature?

[antonmedv]

Sometime soon?... There is no SLO, so you get it -)))

[qoomon]

👀

[qoomon]

🥺

[antonmedv]

Still didn’t find any time. Will try tonight.

[qoomon]

Is there any rough estimation of a release date?

[qoomon]

Can I support to get this PR to be merged?