splitpanes icon indicating copy to clipboard operation
splitpanes copied to clipboard

No resize event when toggling horizontal flag

Open petersutter opened this issue 5 years ago • 2 comments

Currently, when toggling the horizontal flag no resize event is fired, but the sizes of the panes may change.

petersutter avatar Feb 04 '20 16:02 petersutter

Hi @petersutter,

You raise an interesting point. When changing the direction, the width and height are flipped only, no resizing is done from Splitpanes at this stage and that's why no resized event is fired. Also, usually if the user changes the direction, the change is triggered from outside Splitpanes so you know that you are initiating a change of size. But I agree it could make sense to trigger a resized event as well.

Do you mind to let me know your use case and why you need a resized event fired? Cheers.

antoniandre avatar Feb 10 '20 23:02 antoniandre

Hi @antoniandre , Yes the change is triggered from outside (in my case drag & drop) and I also added handling for it, but I wondered why no resized event was fired. So it would be nice to have, but not mandatory of course.

Regarding my use case: I'm working on a splitpane feature for our web terminals with drag and drop support, similar to iTerm2: 2020-02-17_14-54-55 (1)

petersutter avatar Feb 17 '20 14:02 petersutter