grammars-v4 icon indicating copy to clipboard operation
grammars-v4 copied to clipboard

Published 20 hours ago • verified publisher icon antlr

[Scss Grammar] Completed the major grammar refactoring

Open SergeyRusskih opened this issue 3 years ago • 3 comments

Changes

  • Fixed major parsing errors and inconsistencies
  • Removed Java test and replaced them with SASS files

SergeyRusskih avatar Aug 06 '22 22:08 SergeyRusskih

@KvanTTT the JS tests failed but I don't see any exception. Instead, it tells that the parsing succeeded. I'm struggling to understand what the issue was.

SergeyRusskih avatar Aug 08 '22 16:08 SergeyRusskih

Perhaps this?

Process is taking longer than 300 seconds. Killing process.
./scss test /Users/runner/work/grammars-v4/grammars-v4/scss/examples/bootstrap/_variables.scss failed

teverett avatar Aug 08 '22 23:08 teverett

Gotcha! Let me investigate the failures.

SergeyRusskih avatar Aug 09 '22 02:08 SergeyRusskih

Hi @KvanTTT ,

I've addressed the grammar and performance issues. Please, have a look.

SergeyRusskih avatar Aug 23 '22 00:08 SergeyRusskih

@SergeyRusskih thanks!

teverett avatar Aug 23 '22 02:08 teverett

@teverett could you mind not merging requests that need my review?

KvanTTT avatar Sep 19 '22 20:09 KvanTTT