grammars-v4 icon indicating copy to clipboard operation
grammars-v4 copied to clipboard

stringtemplate/ issues...

Open kaby76 opened this issue 4 years ago • 0 comments

stringtemplate/ has a few problems that should be addressed:

  • Grammar ST{Parser,Lexer}.g4 is a grammar for regular StringTemplate.
  • Grammar STG{Parser,Lexer}.g4 is a grammar for StringTemplate group.
  • These should be separated into two sub-directories, e.g., follow antlr/antlr{2,3,4}.
  • Only ST{Parser,Lexer}.g4 is actually tested on input, and only one test file is provided.
  • I don't know what version these grammars are for. It might be best to start from scratch, convert the Antlr3 grammars of StringTemplate using trconvert, and work with that.
  • There's no readme.
  • Lexunicode.g4 (an include file) is included in LexBasic.g4, but not one rule is used!
  • LexBasic.g4 uses a couple of predicates to check Java letter, but it differs from Java/java with JavaLetterOrDigit.
  • It places some of the predicates in a lexer base class.

kaby76 avatar Apr 29 '21 06:04 kaby76