linenoise icon indicating copy to clipboard operation
linenoise copied to clipboard

Move terminal escape sequence handling into a function and reuse in c…

Open UplinkCoder opened this issue 1 year ago • 4 comments

…ompletion code

This allow escape sequences to work while within a completion cycle. allowing prefix to work as expected.

UplinkCoder avatar Aug 12 '24 12:08 UplinkCoder

Hi, I saw your modification on escape sequence handling. Is the handling work fine on your project? In my project, when I press 'Up' key, It sometimes (when I press 'Up' key fast) not go up, just print '[A' or 'A' or '[', which is the real code of 'Up' key.

https://github.com/antirez/linenoise/blob/d895173d679be70bcd8b23041fff3e458e1a3506/linenoise.c#L1025

zlaazlaa avatar Aug 19 '24 03:08 zlaazlaa

Thanks for testing it @zlaazlaa I have not pressed the up key fast yet. I will have a look now.

UplinkCoder avatar Aug 24 '24 17:08 UplinkCoder

@zlaazlaa I cannot reproduce it. can you maybe do an asciicinema capture of it?

UplinkCoder avatar Aug 24 '24 18:08 UplinkCoder

@zlaazlaa I cannot reproduce it. can you maybe do an asciicinema capture of it?

I did more test, I think it's the problem of the serial on my project. Thinks for your answer

zlaazlaa avatar Aug 25 '24 08:08 zlaazlaa