Dilshod Tadjibaev
Dilshod Tadjibaev
I am currently working on this.
After https://github.com/tracel-ai/burn/pull/3872 is merged refactor Rc lifetime hack.
That would be a good addition. I saw @wingertge implementation (https://github.com/wingertge/craft-burn/blob/5f02609dadfe206aeb4c16db873446fd80101bd2/src/lib.rs). Maybe @wingertge can also give a feedback on this. This is how it was used: https://github.com/wingertge/craft-burn/blob/5f02609dadfe206aeb4c16db873446fd80101bd2/src/refine.rs#L27
Closing this for now. The design needs to be flushed out.
@laggui let me know if this addresses your async concern in burn-import
> If `into_data` is used to have a scalar, this is definitivly wrong. We should keep the tensor instead. Maybe in the Burn API we could introduced a scalar enum:...
Reported on the discord: https://discord.com/channels/1038839012602941528/1144670451763785769/1373027679418454016 Hi ! I'm trying to import this [onnx model](https://drive.google.com/uc?id=1x5Tct5hOCIOve229LNRrk2axWQFwojwU) ``` ERROR burn_import::logger: PANIC => panicked at C:\Users\A2va\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\burn-import-0.17.0\src\burn\ty.rs:122:19: "inception_resnet_v1/lambda_23/mul/y:0" is not a valid Ident ``` The...
Submitted a fix: #3208 (under a review)
CC @wingertge @nathanielsimard
After this PR merge: https://github.com/tracel-ai/burn/pull/3584 you can run: ``` [onnx-tests]% cargo test --features backend-wgpu ```