Dilshod Tadjibaev
Dilshod Tadjibaev
> I'd say a good place to get inspired by would be PyTorch Lightning's logger module: https://github.com/Lightning-AI/lightning/tree/master/src/lightning/pytorch/loggers Thank you for link. I will check it out!
@bayedieng , if you have some example handy for PyTorch, could you please share it? It would quicken our troubleshooting.
> Sure, I created a torch tensor of ones with the shape `[1, 32, 32, 3]` and applied maxpool2d with a kernel size of `(2,2)`, obtaining the correct output shape...
@nathanielsimard yeah probably good idea. And should make this change before a release since max pool is new.
Re-openning it to make the strides defaults to be equal to kernel
> Hey, @antimora should I take this issue? Yes. Please go ahead.
I agree. Should we search all places where it's used, or do we know where it is used already?
Closing it as too open ended. We will do as we refactor one by one.
We are crucially missing two tensor operations for this: `sign()` and `abs()`. If we had them, then you could do this: ```rust # Get the sign of tensor_a sign_a =...
I guess with the missing ops you could do this: ```rust let sign = tensor.ones_like().mask_fill(tensor.lower_elem(0.0), -1.0); let output_tensor = tensor.powf(2.0).sqrt().mul(sign); ``` Note: I haven't tried it yet myself.