shortest icon indicating copy to clipboard operation
shortest copied to clipboard

fix: consider package managers the user uses when installing browsers via playwright

Open amk-dev opened this issue 11 months ago • 5 comments

Fixs #144

Changes

  1. consider the package manager the user is using when installing chromium with playwright.
  2. the current package manager & the execute command is determinded using antfu-collective/package-manager-detector
  3. removes the setup.ts as discussed here
  4. cleans up the package.json scripts that uses setup.ts

amk-dev avatar Dec 26 '24 19:12 amk-dev

@amk-dev is attempting to deploy a commit to the Antiwork Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 26 '24 19:12 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 26 '24 19:12 CLAassistant

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shortest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2024 2:36pm

vercel[bot] avatar Dec 26 '24 20:12 vercel[bot]

Thanks for waiting will review this soon.

m2rads avatar Dec 27 '24 22:12 m2rads

Merge conflicts to resolve!

slavingia avatar Dec 27 '24 23:12 slavingia

Failed due to not having Anthropic key, not sure why

slavingia avatar Dec 28 '24 14:12 slavingia

Failed due to not having Anthropic key, not sure why

i've tested locally and no issues found. might be some config issue ?

amk-dev avatar Dec 28 '24 16:12 amk-dev

They'll be published, right? Just not included in version notes.

slavingia avatar Dec 29 '24 20:12 slavingia

They'll be published, right? Just not included in version notes.

adding my two cents

usually libraries include even tiny changes,

in this example, having this might not hurt, and even might be helpful when reading back after sometime.

bugfixs

  • consider package managers the user uses when installing browsers via playwright (#PRNUMBER)
  • remove duplicate line from system prompt (#PRNUMBER)

if you're communicating to users through social channels, like twitter / your blog, then it makes sense to skip these and focus on the major things.

but in github, since its mostly devs reading, everything is good to include imo.

amk-dev avatar Dec 29 '24 22:12 amk-dev