pymapdl
pymapdl copied to clipboard
feat: Adding 'methodconfig' for all services in channel that allow to retry
Description
Implement gRPC retries. It should improve the stability of the gRPC interface.
Issue linked
It should also close a lot of issues:
Close #3342 and related.
Checklist
- [x] I have visited and read Develop PyMAPDL.
- [x] I have tested my changes locally
- [x] I have added necessary documentation or updated existing documentation.
- [x] I have followed the PyMAPDL coding style guidelines.
- [x] I have added appropriate unit tests that also ensure the minimal coverage criteria.
- [x] I have reviewed my changes before submitting this pull request.
- [x] I have linked the issue or issues that are solved to the PR if any.
- [x] I have assigned this PR to myself.
- [x] I have marked this PR as
draftif it is not ready to be reviewed yet. - [x] I have made sure that the title of my PR follows Commit naming conventions (e.g.
feat: adding new MAPDL command)
Thanks for opening a Pull Request. If you want to perform a review write a comment saying:
@ansys-reviewer-bot review
Way to test this, using the model from https://github.com/ansys/pymapdl/issues/2479 connecting to v25.1.0 docker image.
Then run:
python compute_for_multiple_mesh_size_wb.py > log.log 2>&1
and then:
$ tail -n 600 -f log.log | grep retrying
I0808 22:01:08.049285000 6143717376 retry_filter_legacy_call_data.cc:2001] chand=0x137076210 calld=0x156e982d0: retrying failed call in 30 ms
I0808 22:01:08.082253000 6143717376 retry_filter_legacy_call_data.cc:2001] chand=0x137076210 calld=0x156e982d0: retrying failed call in 73 ms
I0808 22:01:08.158568000 6143717376 retry_filter_legacy_call_data.cc:2001] chand=0x137076210 calld=0x156e982d0: retrying failed call in 310 ms
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.96%. Comparing base (
93dd176) to head (4a4ae66). Report is 9 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #3343 +/- ##
==========================================
- Coverage 87.13% 86.96% -0.17%
==========================================
Files 55 55
Lines 9816 10959 +1143
==========================================
+ Hits 8553 9531 +978
- Misses 1263 1428 +165
I saw this:
<_InactiveRpcError of RPC that terminated with:
status = StatusCode.UNAVAILABLE
details = "failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:50062: FD shutdown"
debug_error_string = "UNKNOWN:Error received from peer {created_time:"2024-08-08T22:33:17.948629+02:00", grpc_status:14, grpc_message:"failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:50062: FD shutdown"}"
strange
Pinging @greschd in case he has any experience with this topic.
Repinging @greschd and @clatapie
I guess it is time for... @pyansys-ci-bot LGTM.