pyansys-geometry icon indicating copy to clipboard operation
pyansys-geometry copied to clipboard

feat: Add polydata conversors to edges and faces

Open AlejandroFernandezLuces opened this issue 2 years ago • 6 comments
trafficstars

Add polydata methods to Edge and Face classes

AlejandroFernandezLuces avatar Sep 26 '23 09:09 AlejandroFernandezLuces

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@f3c32e8). Click here to learn what that means.

:exclamation: Current head 017adfa differs from pull request most recent head 4d9f56f. Consider uploading reports for the commit 4d9f56f to get more accurate results

Files Patch % Lines
src/ansys/geometry/core/designer/face.py 36.36% 7 Missing :warning:
src/ansys/geometry/core/designer/edge.py 50.00% 4 Missing :warning:
src/ansys/geometry/core/designer/selection.py 80.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #759   +/-   ##
=======================================
  Coverage        ?   91.95%           
=======================================
  Files           ?       78           
  Lines           ?     5554           
  Branches        ?        0           
=======================================
  Hits            ?     5107           
  Misses          ?      447           
  Partials        ?        0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 26 '23 09:09 codecov[bot]

Stopping the development of this branch while we don't have the required info from the server side:

  • Required info to draw circular and curved edges
  • Required info to draw non planar faces

AlejandroFernandezLuces avatar Sep 26 '23 13:09 AlejandroFernandezLuces

Once #655 is merged, I think we can proceed with this one

AlejandroFernandezLuces avatar Nov 22 '23 14:11 AlejandroFernandezLuces

#655 has been merged @AlejandroFernandezLuces - please continue work here

RobPasMue avatar Mar 13 '24 07:03 RobPasMue

Codecov Report

Attention: Patch coverage is 35.29412% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 89.66%. Comparing base (4a4c483) to head (fbac463). Report is 1 commits behind head on main.

Files Patch % Lines
src/ansys/geometry/core/designer/edge.py 22.22% 14 Missing :warning:
src/ansys/geometry/core/designer/face.py 36.36% 7 Missing :warning:
src/ansys/geometry/core/designer/selection.py 80.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
- Coverage   89.94%   89.66%   -0.28%     
==========================================
  Files          93       93              
  Lines        6780     6812      +32     
==========================================
+ Hits         6098     6108      +10     
- Misses        682      704      +22     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 13 '24 16:03 codecov-commenter

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

wiz-inc-572fc38784[bot] avatar Mar 15 '24 15:03 wiz-inc-572fc38784[bot]

Closing since this might be approached differently (eventually)

RobPasMue avatar Feb 13 '25 09:02 RobPasMue