ansible-navigator icon indicating copy to clipboard operation
ansible-navigator copied to clipboard

Get rid of the deprecated `data_files` in favor of `package_data` in packaging

Open webknjaz opened this issue 4 years ago • 0 comments
trafficstars

ISSUE TYPE
  • Bug Report
SUMMARY

$sbj. The replacement would be to also use something like importlib_resources.files() to retrieve the resource paths.

ANSIBLE-NAVIGATOR VERSION

main branch

CONFIGURATION

N/A

LOG FILE

N/A

STEPS TO REPRODUCE

N/A

EXPECTED RESULTS

Non-python files should be managed as package data.

ACTUAL RESULTS

They are wired up via a deprecated option.

ADDITIONAL INFORMATION
  • https://setuptools.rtfd.io/en/latest/references/keywords.html?highlight=data_files
  • https://setuptools.rtfd.io/en/latest/userguide/quickstart.html#including-data-files
  • https://setuptools.rtfd.io/en/latest/userguide/datafiles.html
  • https://packaging.python.org/guides/distributing-packages-using-setuptools/#package-data
  • https://importlib-resources.readthedocs.io/en/latest/migration.html#pkg-resources-resource-listdir

webknjaz avatar Aug 31 '21 20:08 webknjaz