ansible-navigator icon indicating copy to clipboard operation
ansible-navigator copied to clipboard

runner artifact cleanup does not always run

Open cidrblock opened this issue 4 years ago • 3 comments
trafficstars

https://github.com/ansible/ansible-navigator/blob/c2167350fb202aa80427bf352f41eed58e48b232/ansible_navigator/runner/api.py#L149

found while working on https://github.com/ansible/ansible-navigator/pull/496

cidrblock avatar Jun 24 '21 16:06 cidrblock

We could store the directory in args.internals https://github.com/ansible/ansible-navigator/blob/main/src/ansible_navigator/configuration_subsystem/navigator_configuration.py#L150 and do the clean up in cli.py at the exit

cidrblock avatar Oct 18 '21 13:10 cidrblock

Approach-1 the artifact_dir passed by ansible-runner can be set in args to the clean up in cli.py

Approach-2

Handle in signal handler https://docs.python.org/3/library/signal.html

ganeshrn avatar Oct 18 '21 13:10 ganeshrn

@cidrblock I think this issue may have been accidentally closed early. You mentioned here that you wanted this to remain open. https://github.com/ansible/ansible-navigator/pull/1438#issuecomment-1479708160

eamigo avatar Apr 04 '23 15:04 eamigo