ansible-lint icon indicating copy to clipboard operation
ansible-lint copied to clipboard

var_naming_pattern not working for set_fact

Open SpikePy opened this issue 3 years ago • 2 comments

Summary

var_naming_pattern is buggy for set_fact variables

Issue Type
  • Bug Report
Ansible and Ansible Lint details

ansible-lint --version

ansible-lint 6.0.2 using ansible 2.12.4
STEPS TO REPRODUCE

.ansible-lint file:

var_naming_pattern: "^[a-z][a-z0-9_]*[a-z0-9]__[a-z][a-z0-9_]*[a-z0-9]$"

in a role set a variable in defaults/main.yml to:

k8s_grafana_users__namespace: monitoring

in tasks/main.yml set:

- name: foobar
  ansible.builtin.set_fact:
    k8s_grafana_users__namespace: "foo"
Desired Behavior

no error regarding variable pattern neither in defaults nor in the tasks file

Actual Behavior
var-naming: Task uses 'set_fact' to define variables that violates variable naming standards
tasks/main.yml:2 Task/Handler: foobar

defaults/main.yml is ok but set_fact variable with the same name is not ok!

SpikePy avatar Apr 04 '22 15:04 SpikePy

This looks like a good idea, a pull-requests would be welcomed.

ssbarnea avatar Apr 06 '22 12:04 ssbarnea

Hi team, if no one hasn't started to work on this, I'd like to take a look.

nishipy avatar Aug 02 '22 05:08 nishipy