community.rabbitmq icon indicating copy to clipboard operation
community.rabbitmq copied to clipboard
verified publisher icon ansible-collections

rabbitmq_user: Added permissions defaults

Open MiniPierre opened this issue 4 years ago • 5 comments

SUMMARY

This pull request adds default values to each vhost permission set in permission variable if not defined

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

rabbitmq_user

ADDITIONAL INFORMATION

N/A

MiniPierre avatar Jul 07 '21 10:07 MiniPierre

Failing tests seem to be due to missing dependecies and not because of the pull request itself

MiniPierre avatar Jul 07 '21 10:07 MiniPierre

@MiniPierre hi, please

  1. add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment.
  2. could you explain what the issue is? I.e. how these default values will help?
  3. does not this break backwards compatibility?

@chrishoffman @manuel-sousa @jgkirschbaum @h-matsuo you were members of rabbitmq team in ansible/ansible / module authors and you were invited to this repo as maintainers. Are you still interested in supporting the stuff here?

Andersson007 avatar Jul 16 '21 05:07 Andersson007

could you also please rebase the PR https://docs.ansible.com/ansible/latest/dev_guide/developing_rebasing.html#rebasing-your-branch

Andersson007 avatar Jul 16 '21 13:07 Andersson007

cc @MiniPierre ^

Andersson007 avatar Jul 26 '21 10:07 Andersson007

@MiniPierre I'm a fan of merging PRs :wink: Will you have time to rebase this soon?

cognifloyd avatar Sep 09 '21 05:09 cognifloyd