community.rabbitmq icon indicating copy to clipboard operation
community.rabbitmq copied to clipboard

Published 20 hours ago • verified publisher icon ansible-collections

rabbitmq_vhost: add REST APIs support

Open too-common-name opened this issue 8 months ago • 1 comments

SUMMARY

Implement REST APIs support. Fixes #171.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

rabbitmq_vhost

ADDITIONAL INFORMATION

Followed the same behavior of user module: if host is specified the module uses APIs. I think is not the best approach in terms of code reusability, but it doesn't break stuff (probably adding a provider field can be a better implementation as initially suggested in #76).

too-common-name avatar Mar 19 '25 11:03 too-common-name

@csmart @Andersson007 ready for review

too-common-name avatar Mar 19 '25 14:03 too-common-name

@too-common-name hello, could you please add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment

Andersson007 avatar Apr 23 '25 06:04 Andersson007

This looks great and is something we would use - is there any timeline on getting it merged?

charlietw avatar May 02 '25 09:05 charlietw

Hello, I am back from holidays. @charlietw happy to help :) I've just implementend @Andersson007 suggestions.

too-common-name avatar May 05 '25 08:05 too-common-name

@csmart will you have a chance to take a look?

Andersson007 avatar May 06 '25 07:05 Andersson007

thanks for the contribution @too-common-name, this look pretty good to me, I've just put a couple of thoughts in review.

csmart avatar May 11 '25 08:05 csmart