community.rabbitmq icon indicating copy to clipboard operation
community.rabbitmq copied to clipboard

fix(rabbitmq_plugin): add node to module args

Open rockandska opened this issue 4 years ago • 3 comments

SUMMARY

Add node argument to rabbitmq_plugin the same way as other module ( close #59 )

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

rabbitmq_plugin

ADDITIONAL INFORMATION

Integration test and unit test ok Minimal test added

ansible-test units --docker default -v --color --python 3.8
ansible-test integration rabbitmq_plugin --docker default -v --color --python 3.8

@odyssey4me / @Andersson007 : since #101 is still a WIP.

Regards,

rockandska avatar Oct 27 '21 22:10 rockandska

For an obscure reason, previously to ansible 2.12 if the node argument contain an @ as rabbibt@node-1, in cmd output the node is replaced with by '' but the error reflect that the argument -n rabbit@node-1 was provided.

I updated the test to remove @ and be able to test cmd, but there is definitely something odd

rockandska avatar Oct 28 '21 12:10 rockandska

@rockandska good one. Looks good to me. It would be great if you could add suggestions 1 & 2 from @Andersson007

Im0 avatar Oct 30 '21 11:10 Im0

Done

rockandska avatar Nov 02 '21 08:11 rockandska