Added an auth method for GCP

[woodham1]

SUMMARY

The following plugin adds gcp as an auth method.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

auth_method_gcp

ADDITIONAL INFORMATION

Before:

fatal: [localhost]: FAILED! => {"msg": "An unhandled exception occurred while running the lookup plugin 'community.hashi_vault.hashi_vault'. Error was a <class 'ansible.errors.AnsibleOptionsError'>, original message: Invalid value \"gcp\" for configuration option \"plugin_type: lookup plugin: ansible_collections.community.hashi_vault.plugins.lookup.hashi_vault setting: auth_method \", valid values are: ['token', 'userpass', 'ldap', 'approle', 'aws_iam', 'azure', 'jwt', 'cert', 'none']"}

After:

[WARNING]: Collection <collection> does not support Ansible version 2.11.12
ok: [<collection>]

[github-actions[bot]]

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main: https://ansible-collections.github.io/community.hashi_vault/branch/main

[woodham1]

@briantist I can't get the devel unit test error to reproduce on my system, I think I'm close here, but I'd love some guidance to get me over the finish line.

[briantist]

@briantist I can't get the devel unit test error to reproduce on my system, I think I'm close here, but I'd love some guidance to get me over the finish line

It's failing on main too so I think it's completely unrelated to your PR, we'll have to get a fix merged in separately (also I need to fix the docs builds) https://github.com/ansible-collections/community.hashi_vault/actions/runs/9795725759/job/27048587480

[woodham1]

@briantist It's been awhile since I've checked up on this, have the checks in the upstream branch been addressed? Can this be merged?

[briantist]

the upstream issue has been fixed, this PR's branch will need to rebase or merge the upstream changes so it can run again

[woodham1]

@briantist It looks like main is failing again. Apologies for not getting this up in the meantime.

[aghassemlouei]

Could use your help @briantist or @sscheib to get this into main as it has a rather large business impact for us. Thank you in advance!

[sscheib]

@aghassemlouei I am afraid, I am not of any use here, as Red Hat is not maintaining this collection and therefore would need to defer this to @briantist :)

[briantist]

I'm sorry it looks like we have another upstream issue that will need to be fixed now so we can get a passing CI

[aghassemlouei]

No worries @briantist! Other than waiting is there anything else we can do to help the broader codebase?

[aghassemlouei]

Afternoon @briantist; apologies for the nudge but just wanted to see if we could get this into main? This would really help unblock some massive usecases for regulated industries.

[briantist]

@aghassemlouei sorry for the delays, I really need to fix the CI and compatibility with 2.19 before merging anything else, and unfortunately that is also moving slowly:

• https://github.com/ansible-collections/community.hashi_vault/issues/464

[aghassemlouei]

No worries @briantist; I completely understand the time and effort that goes into validating major releases. Appreciate you keeping this issue updated!

[briantist]

The CI issues have been addressed and this can be rebased. I will be looking to do a major release within less than a week so not sure if this can make it before then but let's at least get it running against the current CI.

[woodham1]

Merged, all checks passed.

[woodham1]

@briantist bump.

[aghassemlouei]

Afternoon @briantist, is there anything else we are missing here to get this into main?

[woodham1]

@briantist for your review.

[woodham1]

@briantist sorry to bother you, but bumping this thread. Let me know if you need anything else, happy to help :)

[nizmitz]

@briantist bumping on this thread also, as this is a nice feature to have

[aghassemlouei]

Apologies for being a bother @briantist but having this pull request merged into main would be immensely beneficial for us. It appears as though all the feedback and tests have passed so if there is anything else that is necessary please don't hesitate to reach out.

[briantist]

Hey all, first of all, it's not bothering me to ask about the status, thanks for the continued interest! I'm the only maintainer and my time is very limited so thanks again for the patience and the reminders.

---

It looks like https://github.com/ansible-collections/community.hashi_vault/pull/442/commits/83d3cfcfb4ed68ba43205df7784d00fd4b5a74dc was addressing the same thing I merged recently in #482 and there's now a (rather minor) conflict.

Let's either revert https://github.com/ansible-collections/community.hashi_vault/pull/442/commits/83d3cfcfb4ed68ba43205df7784d00fd4b5a74dc or keep it and resolve the conflict.

Please also rebase/merge main so we get the latest CI, once we have that passing I will look to get this merged as soon as I can

[briantist]

Thank you very much @woodham1 for the contribution and thanks to everyone for their patience

[briantist]

This has been released in v7.1.0