namada icon indicating copy to clipboard operation
namada copied to clipboard

Fix shielded sync scanned progress bar limit

Open sug0 opened this issue 1 year ago • 3 comments

Describe your changes

Fixes the limit of the scanned progress bar in shielded sync being lower than the current value.

Example

Scanned 0 0
ShieldedBalanceChart.tsx:27 Scanned 1 3
ShieldedBalanceChart.tsx:27 Scanned 2 3
ShieldedBalanceChart.tsx:27 Scanned 3 3
ShieldedBalanceChart.tsx:27 Scanned 4 3
ShieldedBalanceChart.tsx:27 Scanned 5 3
ShieldedBalanceChart.tsx:27 Scanned 6 3
ShieldedBalanceChart.tsx:27 Scanned 7 5
ShieldedBalanceChart.tsx:27 Scanned 8 5
ShieldedBalanceChart.tsx:27 Scanned 9 5
ShieldedBalanceChart.tsx:27 Scanned 10 5
ShieldedBalanceChart.tsx:27 Scanned 11 7
ShieldedBalanceChart.tsx:27 Scanned 12 7
ShieldedBalanceChart.tsx:27 Scanned 13 7
ShieldedBalanceChart.tsx:27 Scanned 14 8
ShieldedBalanceChart.tsx:27 Scanned 15 8
ShieldedBalanceChart.tsx:27 Scanned 16 8
ShieldedBalanceChart.tsx:27 Scanned 17 10
ShieldedBalanceChart.tsx:27 Scanned 18 10
ShieldedBalanceChart.tsx:27 Scanned 19 10

Checklist before merging

  • [ ] If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • [ ] If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • [ ] If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

sug0 avatar Nov 19 '24 13:11 sug0

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.26%. Comparing base (fb3a7cd) to head (00904e4). Report is 619 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4046   +/-   ##
=======================================
  Coverage   74.25%   74.26%           
=======================================
  Files         341      341           
  Lines      107325   107332    +7     
=======================================
+ Hits        79699    79711   +12     
+ Misses      27626    27621    -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 19 '24 13:11 codecov[bot]

@mateuszjasiuk reported this PR doesn't entirely fix the issue

sug0 avatar Nov 20 '24 09:11 sug0

@sug0 what is the status of this PR right now?

brentstone avatar Dec 25 '24 00:12 brentstone

I think we can close this

sug0 avatar Feb 25 '25 10:02 sug0