namada icon indicating copy to clipboard operation
namada copied to clipboard

Encrypt validator keys

Open sug0 opened this issue 1 year ago • 9 comments

Allow encrypting validator keys in wallet.toml.

sug0 avatar May 15 '24 10:05 sug0

cc @cwgoes @tzemanovic should we implement this for phase 1?

sug0 avatar May 15 '24 12:05 sug0

It's not a hard requirement for the release candidate, but we should implement it ASAP.

cwgoes avatar May 15 '24 18:05 cwgoes

@sug0 Which keys are you talking about specifically?

cwgoes avatar Aug 22 '24 07:08 cwgoes

@cwgoes these keys, which also live in wallet.toml https://github.com/anoma/namada/blob/f5c3b708018c38bb8768da57ce3199a208ff9e12/crates/sdk/src/wallet/store.rs#L38-L45

sug0 avatar Aug 22 '24 07:08 sug0

I see - do I understand correctly then that these keys are not currently used (they would be used for the Ethereum bridge)?

cwgoes avatar Aug 26 '24 08:08 cwgoes

yeah, they're currently only required by the eth bridge code, which is deactivated anyway

sug0 avatar Aug 26 '24 20:08 sug0

What are thoughts on removing these keys altogether?

brentstone avatar Aug 26 '24 22:08 brentstone

that answer depends on the premise that the eth bridge is never gonna be enabled. 🤷 we could always add these keys back to the wallet, but idk. @cwgoes

sug0 avatar Aug 27 '24 08:08 sug0

Let's just leave this issue for now.

cwgoes avatar Aug 27 '24 08:08 cwgoes