namada icon indicating copy to clipboard operation
namada copied to clipboard

Refactor `namadac balance`

Open brentstone opened this issue 1 year ago • 2 comments

  • [x] Require the owner argument, as the current impl without this arg provided tries to loop over the balances of all accounts, which is way too intensive and should not be allowed
  • [ ] MASP strategy is too intensive and should be changed
    • #2900
  • [x] Non-native (IBC) token strategy is also too intensive, should not be scanning over all tokens in the chain for balances.

Previous related issues:

  • #2887
  • #2809
  • #2666

brentstone avatar Apr 06 '24 09:04 brentstone

@Fraccaman @cwgoes I think this should probably be a Phase 1 priority, what do you think?

brentstone avatar Apr 06 '24 09:04 brentstone

Decisions 2024.04.24:

  • Require --owner always (which will be a transparent or shielded address)
    • Implies shielded/transparent
  • Require --token always
  • Clean up / clarify error messages
  • Clarify in the description what the command does and does not do
    • Does not scan all tokens

cwgoes avatar Apr 24 '24 15:04 cwgoes