namada
namada copied to clipboard
Replay protection refactor
Describe your changes
Closes #2922.
Since there's no more need to keep track and possibly act on tx cases from different block, this PR removes the ReProtStorageModification enum and uses a simple HashSet to keep track of the transaction hashes.
Also improves replay protection unit tests.
Indicate on which release or other PRs this topic is based on
v0.33.0
Checklist before merging to draft
- [x] I have added a changelog
- [x] Git history is in acceptable state
Codecov Report
Attention: Patch coverage is 96.72131% with 4 lines in your changes are missing coverage. Please review.
Project coverage is 59.37%. Comparing base (
97ec5b4) to head (bed0517). Report is 10 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| crates/state/src/write_log.rs | 92.59% | 2 Missing :warning: |
| crates/storage/src/mockdb.rs | 93.54% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2956 +/- ##
==========================================
- Coverage 59.39% 59.37% -0.02%
==========================================
Files 298 298
Lines 92771 92685 -86
==========================================
- Hits 55104 55036 -68
+ Misses 37667 37649 -18
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
is this still just awaiting a final review?