namada icon indicating copy to clipboard operation
namada copied to clipboard

less permissive VPs

Open tzemanovic opened this issue 2 years ago • 2 comments

Describe your changes

fixes #408

Unknown changes in vp_user and vp_implicit now require valid signature(s).

For PoS changes, we have to check against all possible storage changes that can be applied from a tx and require signature(s) for those that have to be authorized by the source (for vp_user it can be both delegator and validator actions, for vp_implicit only delegator actions). If the change within PoS account subspace is not recognized we default to require sig(s).

To ease debugging in vp_user and vp_implicit, I changed the logging of rejected keys to also be be emitted in release build.

Indicate on which release or other PRs this topic is based on

v0.28.0

Checklist before merging to draft

  • [x] I have added a changelog
  • [x] Git history is in acceptable state

tzemanovic avatar Nov 23 '23 14:11 tzemanovic

looks like lots of e2e tests are affected, looking into it

tzemanovic avatar Nov 23 '23 15:11 tzemanovic

there are some more changes needed for IBC

tzemanovic avatar Nov 27 '23 10:11 tzemanovic