namada icon indicating copy to clipboard operation
namada copied to clipboard

Code coverage audit, rework to obtain coverage w/o large E2E tests

Open cwgoes opened this issue 2 years ago • 6 comments

A lot of our coverage is provided by two large E2E tests (MASP & ledger transactions), which should be mostly replaced with / supplanted by unit / prop tests with proper mocks so that we can reach sufficient coverage.

cwgoes avatar Jun 02 '23 10:06 cwgoes

to my knowledge make test-unit-coverage skips e2e

tzemanovic avatar Jun 05 '23 06:06 tzemanovic

Hmm - in that case @batconjurer or @mariari can you clarify the concern here?

cwgoes avatar Jun 05 '23 10:06 cwgoes

I agree that MASP should have unit / integration / prop tests. There's nothing to catch issues in it besides e2e tests and the lack of these tests is being a serious issue for the more complex integrations

tzemanovic avatar Jun 20 '23 10:06 tzemanovic

@tzemanovic @batconjurer @Fraccaman how relevant is this issue still?

brentstone avatar Apr 10 '24 00:04 brentstone

I think coverage is still low especially for MASP.

Fraccaman avatar Apr 12 '24 13:04 Fraccaman