Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

feat(new reviewer): answer timer

Open voczi opened this issue 1 year ago • 2 comments

(Copy&paste from old PR: https://github.com/ankidroid/Anki-Android/pull/16898)

Purpose / Description

Add answer timer to the new reviewer.

Fixes

N/A.

Approach

New answer timer is added to the top-right corner in the new reviewer, along with related logic.

How Has This Been Tested?

Tested in emulator, API 34.

Learning (optional, can help others)

N/A.

Checklist

  • [x] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [x] You have commented your code, particularly in hard-to-understand areas
  • [x] You have performed a self-review of your own code
  • [x] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

https://github.com/user-attachments/assets/12203110-2f01-4429-8216-ae9ac1dfdfdd

voczi avatar Oct 07 '24 13:10 voczi

@david-allison Hope the code looks better now.

voczi avatar Oct 07 '24 13:10 voczi

I've reviewed and written the necessary fixes and changes I wanted. My current time window is gone and I want to revisit the code after some time so I can get a fresher mind to evaluate if the code can get better.

I think I'll be able to send the patch by monday, but maybe later.

BrayanDSO avatar Oct 12 '24 16:10 BrayanDSO

Seems useful but appears to need a new dev

mikehardy avatar Nov 09 '24 13:11 mikehardy