Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

Improve "download failed" message for Shared Decks

Open david-allison opened this issue 1 year ago • 6 comments

From user report: https://www.reddit.com/r/Anki/comments/1fu0cdi/ankidroid_download_failure/


If a download fails, we should provide a link to open the deck on the AnkiWeb site, so a user may download the file manually

Relevant file:

https://github.com/ankidroid/Anki-Android/blob/main/AnkiDroid/src/main/java/com/ichi2/anki/SharedDecksDownloadFragment.kt

david-allison avatar Oct 02 '24 01:10 david-allison

Hello, I would like to work on it. Please let me know if I can take this up

Raman-Khiva avatar Oct 02 '24 06:10 Raman-Khiva

Thanks!!

david-allison avatar Oct 02 '24 11:10 david-allison

Hello, I want to work on this issue, would you please assign me .

salehdemir avatar Oct 10 '24 09:10 salehdemir

Sounds good, thanks!

david-allison avatar Oct 10 '24 09:10 david-allison

Wait, this was only assigned a few days ago, give @Raman-Khiva a chance

david-allison avatar Oct 10 '24 09:10 david-allison

Ok sir, Thanks

salehdemir avatar Oct 10 '24 09:10 salehdemir

hello !! if no one is working upon this , can i go ahead ?

Sanskriti0805 avatar Oct 26 '24 18:10 Sanskriti0805

Sounds good @Sanskriti0805, thanks!

david-allison avatar Oct 27 '24 00:10 david-allison

Hi @david-allison !, I've been working on this issue and would appreciate it if you could take a look to confirm whether it's on the right track. Image

Since this issue has already been assigned, I wanted to check if they’re actively working on it or if collaboration might be helpful. Or if you'd prefer me to wait for their progress.

disconnect821 avatar Nov 01 '24 17:11 disconnect821

i m working on it currently @disconnect821 but can collaborate , if you are comfortable

Sanskriti0805 avatar Nov 01 '24 20:11 Sanskriti0805

Hey @Sanskriti0805! Once @david-allison approves or shares any suggestions on the draft, I'd be happy to collaborate.

disconnect821 avatar Nov 02 '24 14:11 disconnect821

I haven't seen a draft, but I'd expect it to be public as a PR/branch so you'd be able to collaborate immediately

Very little point in doing things in private here

david-allison avatar Nov 02 '24 15:11 david-allison

sure sir

Sanskriti0805 avatar Nov 02 '24 15:11 Sanskriti0805

Let me work on this issue

shkshreyas avatar Jan 13 '25 12:01 shkshreyas

@shkshreyas have you noticed that there is a PR open for this already? Have you checked on the status of that? Looks like it may be close to merge, meaning this issue isn't a good one to take on as you will duplicate effort

mikehardy avatar Jan 13 '25 13:01 mikehardy

hello @disconnect821 have you worked upon this one or would like to continue upon ?

Sanskriti0805 avatar Mar 09 '25 04:03 Sanskriti0805

Awaiting review from @Arthur-Milchior on the PR. If you have any suggestions or improvements, feel free to share them or you can make changes directly on the branch.

disconnect821 avatar Mar 09 '25 05:03 disconnect821