Github Actions: Adopt JDK distribution is no longer maintained

[tabasavr]

I was copying Github actions for tests from your project and noticed that you use adopt distribution:

      - name: Configure JDK 1.11
        uses: actions/setup-java@v3
        with:
          distribution: "adopt"
          java-version: "11" # ubuntu-latest is about to default to 11, force it everywhere

According to the docs

Adopt OpenJDK got moved to Eclipse Temurin and won't be updated anymore. It is highly recommended to migrate workflows from adopt to temurin to keep receiving software and security updates. See more details in the Good-bye AdoptOpenJDK post.

[welcome[bot]]

Hello! 👋 Thanks for logging this issue. Please remember we are all volunteers here, so some patience may be required before we can get to the issue. Also remember that the fastest way to get resolution on an issue is to propose a change directly, https://github.com/ankidroid/Anki-Android/wiki/Contributing

[mikehardy]

Sure, you're not wrong. I've switched to temurin in most of the repos I manage, and will get to this eventually. Are you interested in posting a PR to remedy it? That would be awesome :sweat_smile:

[mikehardy]

Also worth noting that if you are on an M1 processor you'll want zulu instead, and in fact zulu may be best as a simple default since it's m1-native already (temurin won't be for jdk11 until later in the year if I understand their roadmap correctly) while zulu already is and works fine on x86-64 mac as well

[tabasavr]

Also worth noting that if you are on an M1 processor you'll want zulu instead, and in fact zulu may be best as a simple default since it's m1-native already (temurin won't be for jdk11 until later in the year if I understand their roadmap correctly) while zulu already is and works fine on x86-64 mac as well

Github-hosted M1 runners are still in the "future" so it might not matter: https://github.com/github/roadmap/issues/528

Anyway, I've run actions on my fork with both distributions a couple of times - temurin and zulu - and they both work fine. Run times are all over the place, but definitely in the same range as right now. So let me know which version you want and I'll open a pr.

[mikehardy]

Sorry for the delay - just now getting caught up on things after travel. Let's go with temurin for now. Thanks!