vector-python-sdk icon indicating copy to clipboard operation
vector-python-sdk copied to clipboard

Published 20 hours ago • verified publisher icon anki

python 3.8 support

Open grant-olson opened this issue 5 years ago • 1 comments
trafficstars

We should support python 3.8 or if that proves too difficult we should have a friendly error message instead of a big ugly traceback in the futures code.

grant-olson avatar Apr 26 '20 20:04 grant-olson

Hi there. The SDK actually run fine on python3.8.. it's just that the futures in 3.8 slightly changed the error handling. The problem with the "big ugly traceback" is that the connection is closed / destoried before all the listeners were shutdown. That was no problem in 3.7 and before and just failed silently. I'm not that deep into python yet, but in the SDK fork I did some time ago, I just workaround that's bug with a simple little timeout, see this lines:

https://github.com/ikkez/vector-python-sdk/commit/103fda2bf84ab4c31feb85863c528d816556bc12

That seems to work just fine, but there's probably a better, more correct way to solve that.

ikkez avatar May 12 '20 14:05 ikkez