NPE in isOneTimePurchaseSupported method

[kal27]

trafficstars

I am getting this error for some of the purchases,

lang.java.NullPointerException: (Attempt to invoke interface method 'int com.android.vending.billing.IInAppBillingService.isBillingSupported(int, java.lang.String, java.lang.String)' on a null object reference) at v3.iab.android.anjlab.com.BillingProcessor.isOneTimePurchaseSupported(BillingProcessor.java:242)

It seems to occur when the isOneTimePurchaseSupported method is called on the BillingProcessor. It is worth noting that it does not occur for every purchase - some of the purchases are successful I am using 1.0.38 version of this library.

[serggl]

@kal27 seem like we need to add a check for isInitialized() at the beginning of this method. Do you want to contribute with a PR?

[DesigningKnights]

To solve this issue for myself, I put the check for isOneTimePurchaseSupported in the onBillingInitialized method, like so:

 @Override
    public void onBillingInitialized() {
    /*
    * Called when BillingProcessor was initialized and it's ready to purchase
    */

        isOneTimePurchaseSupported = billingProcessor.isOneTimePurchaseSupported();
    }

This ensures the billingProcessor object was initialized and is not null.

[jangrewe]

@DesigningKnights I am using something like that, and that's exactly what's causing the issue, as isOneTimePurchaseSupported() calls isBillingSupported(), and the NPE happens then in isBillingSupported().

Fatal Exception: java.lang.NullPointerException
Attempt to invoke interface method 'int com.android.vending.billing.IInAppBillingService.isBillingSupported(int, java.lang.String, java.lang.String)' on a null object reference

com.anjlab.android.iab.v3.BillingProcessor.isOneTimePurchaseSupported (SourceFile:394)
org.faked.isms2droid.MainActivity$1.onBillingInitialized (SourceFile:324)
...

[bidy]

I have the same bug - according to google play prelauch.

[sikaiser]

I think this is more or less the same as #302. Still having this problem too.

[ardovic]

Submitted PR, it passed tests, looking forwards for review

[jangrewe]

@serggl Will there be a new release any time soon? I squashed all bugs in my app, except for this one...

[serggl]

@jangrewe if you refer to #376 -I would recommend you to link your project with a master branch of this repo.

[jangrewe]

I'm not sure what you mean with "link your project with a master branch of this repo"? I'm using the library via Maven, so i guess unless there's a snapshot of the master branch in the Maven repo, i'd have to build it myself? That's something i'd rather not do! ;-)