anitab-forms-web icon indicating copy to clipboard operation
anitab-forms-web copied to clipboard

Bug: Streamwise messages not showing on zulip stat card to admin

Open codesankalp opened this issue 4 years ago • 22 comments

Describe the bug

Streamwise messages are not showing on zulip stat to admin because the condition to check streamwise messages is wrong. We need to delete this condition of checking all streamwise messages by checking the message in the newcomer stream, as it is not required. To test the message

To Reproduce

Steps to reproduce the behavior:

  1. Go to http://localhost:8000/admin/osp/userinformation/
  2. Edit one of the admin user-information and insert 345277 in zulip id.
  3. Now go to this http://localhost:3000/ and log in using the credentials of the user which you have edited previously.
  4. Reload the zulip stats and now you can see that streamwise messages do not show up.

Expected behavior

Streamwise messages do not show up when the student has no message in the newcomer stream.

Screenshots

image

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser: Chrome
  • Version: _

How to solve

To solve this issue remove the condition of checking the stream messages by checking message in newcomer stream. https://github.com/anitab-org/open-source-programs-web/blob/ab18727af5a5e30829e4d07935a218c6d8a02762/src/components/Zulip.js#L39-L51

I have tested by removing it, it is working fine.

Time Required to solve this issue

  • 10 to 15 minutes.

codesankalp avatar Feb 08 '21 08:02 codesankalp

@isabelcosta Can you please add labels to this issue? As It is a beginner issue so a newcomer can solve this issue :relaxed:

codesankalp avatar Feb 09 '21 15:02 codesankalp

thank you @codesankalp for helping triage!

isabelcosta avatar Feb 09 '21 23:02 isabelcosta

@isabelcosta Ma'am if this issue is not assigned can I take it

prachinandi avatar Feb 11 '21 12:02 prachinandi

yes @prachi237 🤗 Will assign it to you!

isabelcosta avatar Feb 11 '21 20:02 isabelcosta

Thanku ma'am😊

prachinandi avatar Feb 11 '21 21:02 prachinandi

@prachi237 Any updates on this issue? Do you need any help or suggestion?

codesankalp avatar Feb 24 '21 15:02 codesankalp

@prachi237 Any updates on this issue? Do you need any help or suggestion? 😅sorry, for the delay I had exams, I started working on this issue again . Will send the PR asap

prachinandi avatar Feb 25 '21 12:02 prachinandi

@prachi237 Is your exams over and can you make a PR on this?

codesankalp avatar Mar 20 '21 14:03 codesankalp

Unassigning @prachi237 due to inactivity.

codesankalp avatar Apr 12 '21 11:04 codesankalp

if this is still available can i take this?

sidharth3000 avatar May 20 '21 12:05 sidharth3000

Yess it is assigned you here, Do ask if you have any doubts

Aaishpra avatar May 20 '21 15:05 Aaishpra

project is not setting up, its giving me error. Screenshot 2021-05-20 231846

sidharth3000 avatar May 20 '21 17:05 sidharth3000

Have you setup the backend correctly and is it running?

codesankalp avatar May 20 '21 17:05 codesankalp

yes now its running, i had to bump up several dependencies. Now if i am not wrong i just have to remove this line. is it right? Screenshot 2021-05-21 172530

sidharth3000 avatar May 21 '21 11:05 sidharth3000

@sidharth3000 any updates?

vj-codes avatar Aug 14 '21 20:08 vj-codes

@sidharth3000 removed your assignment due to a lack of activity. Feel free to claim again, if you want to work on it

isabelcosta avatar Oct 01 '21 19:10 isabelcosta

@isabelcosta can you assign this issue to me?

msaini28r avatar Oct 14 '21 11:10 msaini28r

@msaini0r , @codesankalp assigned this ticket to you :)

isabelcosta avatar Oct 14 '21 22:10 isabelcosta

@isabelcosta please merge the pull request.

msaini28r avatar Oct 15 '21 05:10 msaini28r

if this is still available can i take this?

indravijay-bot avatar Dec 22 '22 16:12 indravijay-bot

Hello @codesankalp, I request you to grant me the access to work on this issue. Regards ASP

ASP124 avatar Sep 14 '23 07:09 ASP124

Hey @codesankalp, @isabelcosta i see that the issue is still open and left since a while and so i want to take this up if it is available but before picking it i wanted to ask if the steps mentioned in the HOW TO SOLVE section of the description is up to date coz i see that @msaini28r had followed it and ran into some issues. I wanted to confirm before starting to not to waste your time. Thank you!

@msaini28r msaini28r mentioned this issue on Oct 15, 2021 https://github.com/anitab-org/anitab-forms-web/pull/180

AaryaDarisi avatar Feb 23 '24 18:02 AaryaDarisi