anitab-forms-backend icon indicating copy to clipboard operation
anitab-forms-backend copied to clipboard

Added Google OAuth Signup in the backend

Open chinmaym07 opened this issue 4 years ago • 13 comments

Description

Fixes #30

Type of Change:

  • Code
  • Quality Assurance
  • Documentation

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

osp Screenshot_2021-03-05 Google Login – Django REST framework Screenshot_2021-03-05 Google Login – Django REST framework(1)

Checklist:

  • [x] My PR follows the style guidelines of this project
  • [x] I have performed a self-review of my own code or materials
  • [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] Any dependent changes have been merged
  • [x] I have updated dependencies in requirements.txt

Code/Quality Assurance Only

  • [x] My changes generate no new warnings

chinmaym07 avatar Mar 05 '21 12:03 chinmaym07

@chinmaym07 can you please fix the conflicts.

Amulya-coder avatar Mar 08 '21 08:03 Amulya-coder

@chinmaym07 Please resolve the merge conflicts and write a test for your implementation.

codesankalp avatar Mar 11 '21 09:03 codesankalp

@chinmaym07 can you please update your branch? That way tests may pass

isabelcosta avatar Apr 02 '21 17:04 isabelcosta

@chinmaym07 can you please update your branch? That way tests may pass

Yes @isabelcosta I am writing a test for Google Oauth signup ..I'll update the branch with it .Sorry for the inconvenience

chinmaym07 avatar Apr 02 '21 18:04 chinmaym07

no inconvenience at all :)

isabelcosta avatar Apr 02 '21 18:04 isabelcosta

@chinmaym07 Any updates?

codesankalp avatar Apr 14 '21 15:04 codesankalp

@codesankalp I will soon complete this ..Sorry for the delay..

chinmaym07 avatar Apr 15 '21 18:04 chinmaym07

@chinmaym07 Can you update your progress @chinmaym07?

codesankalp avatar May 09 '21 11:05 codesankalp

Codecov Report

Merging #112 (fb0f480) into develop (426773d) will increase coverage by 0.44%. The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #112      +/-   ##
===========================================
+ Coverage    64.88%   65.32%   +0.44%     
===========================================
  Files           64       65       +1     
  Lines         1031     1047      +16     
===========================================
+ Hits           669      684      +15     
- Misses         362      363       +1     
Impacted Files Coverage Δ
main/settings.py 76.19% <83.33%> (+1.19%) :arrow_up:
token_auth/urls.py 100.00% <100.00%> (ø)
token_auth/views/google_oauth.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 426773d...fb0f480. Read the comment docs.

codecov-commenter avatar May 10 '21 08:05 codecov-commenter

@codesankalp I have tried to write the test . There is still the problem of mocking the api . I tried it .. but it didn't work out .. Can you please have a look ..

chinmaym07 avatar May 10 '21 09:05 chinmaym07

@chinmaym07 Can you update your progress here?

codesankalp avatar Jul 22 '21 16:07 codesankalp

@chinmaym07 Can you update your progress here?

So Sorry for the delay here .. Will update both the PR's by this week .

chinmaym07 avatar Jul 25 '21 19:07 chinmaym07

@chinmaym07 feel free to drop the issue. you can always come back later when you become available ;)

isabelcosta avatar Jul 29 '21 22:07 isabelcosta