anitab-forms-backend
anitab-forms-backend copied to clipboard
Added Google OAuth Signup in the backend
Description
Fixes #30
Type of Change:
- Code
- Quality Assurance
- Documentation
Code/Quality Assurance Only
- This change requires a documentation update (software upgrade on readme file)
- New feature (non-breaking change which adds functionality pre-approved by mentors)
How Has This Been Tested?

Checklist:
- [x] My PR follows the style guidelines of this project
- [x] I have performed a self-review of my own code or materials
- [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] Any dependent changes have been merged
- [x] I have updated dependencies in
requirements.txt
Code/Quality Assurance Only
- [x] My changes generate no new warnings
@chinmaym07 can you please fix the conflicts.
@chinmaym07 Please resolve the merge conflicts and write a test for your implementation.
@chinmaym07 can you please update your branch? That way tests may pass
@chinmaym07 can you please update your branch? That way tests may pass
Yes @isabelcosta I am writing a test for Google Oauth signup ..I'll update the branch with it .Sorry for the inconvenience
no inconvenience at all :)
@chinmaym07 Any updates?
@codesankalp I will soon complete this ..Sorry for the delay..
@chinmaym07 Can you update your progress @chinmaym07?
Codecov Report
Merging #112 (fb0f480) into develop (426773d) will increase coverage by
0.44%. The diff coverage is94.11%.
@@ Coverage Diff @@
## develop #112 +/- ##
===========================================
+ Coverage 64.88% 65.32% +0.44%
===========================================
Files 64 65 +1
Lines 1031 1047 +16
===========================================
+ Hits 669 684 +15
- Misses 362 363 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| main/settings.py | 76.19% <83.33%> (+1.19%) |
:arrow_up: |
| token_auth/urls.py | 100.00% <100.00%> (ø) |
|
| token_auth/views/google_oauth.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 426773d...fb0f480. Read the comment docs.
@codesankalp I have tried to write the test . There is still the problem of mocking the api . I tried it .. but it didn't work out .. Can you please have a look ..
@chinmaym07 Can you update your progress here?
@chinmaym07 Can you update your progress here?
So Sorry for the delay here .. Will update both the PR's by this week .
@chinmaym07 feel free to drop the issue. you can always come back later when you become available ;)