Gamecord
Gamecord copied to clipboard
aniket091
Add guess the number game
Changes
describe what changes this PR includes and explain why are they needed
Screenshots
If applicable, add screenshots to explain the change.
Status
- [x] These changes have been tested and formatted properly.
- [x] These changes also include the change in documentation accordingly.
- [ ] This PR introduces some Breaking changes
One thing caught my attention, why is a yarn.lock file added?
Tbh, I have no idea 😂. I always add it to all my projects. I can remove it if Aniket say so.
This pull request probably won't be merged until the new bug fix update is published.
Yes, the owner of the repo (Aniket) have told me in discord about this.
One thing caught my attention, why is a yarn.lock file added?
Tbh, I have no idea 😂. I always add it to all my projects. I can remove it if Aniket say so.
You should probably remove the yarn.lock then. It isn't necessary here, and it may cause some issue.
I just read. yarn.lock provide yarn on the information about dependencies of the project and tell yarn how to manage the project. The post states that, if you do not push lock files (package-lock.json, yarn.lock), it could cause issues on other machines. Thus, I will be keeping this file for now and I will remove it when the pull request is getting close to merging.
Oh 😅 I didn't realise the pull request was open haha. I was just clearing out repos that I am inactive on.