protractor icon indicating copy to clipboard operation
protractor copied to clipboard

feat(saucelabs): Removed unnecessary username and accesskey from cap…

Open sirwalt opened this issue 8 years ago • 4 comments

…abilities and fixed build in capabilities to be only overwritten under condition

There was no actual reason to set username and accesskey as capabilities on the selenium driver. Sourcelabs doesn't require those.

Overwriting the build capability from the sauceBuild config parameter seams to be logical since it couldn't differ between multiple capabilities within a single build, but it is unexpected. Without any check if the value of souceBuild is defined, there is no chance to set it within capabilities as someone is used to do.

sirwalt avatar May 13 '17 01:05 sirwalt

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar May 13 '17 01:05 googlebot

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar May 13 '17 01:05 googlebot

CLAs look good, thanks!

googlebot avatar May 16 '17 11:05 googlebot

CLAs look good, thanks!

googlebot avatar May 16 '17 11:05 googlebot