material icon indicating copy to clipboard operation
material copied to clipboard

datepicker: cannot set autocomplete property in generated input tag

Open TheManuz opened this issue 5 years ago • 3 comments

Bug

Detailed Reproduction Steps:

  1. Create an md-datepicker, nested inside an md-input-container, nested inside a form.
  2. Assign a name property to md-datepicker ("releaseDate" and "expirationDate" in my case)
  3. Have Chrome autofill enabled with autocomplete fields available (specifically "email" in my case)

What is the expected behavior?

Autofill should not try to populate a datepicker.

md-datepicker should have an attribute like md-input-autocomplete that should set the "autocomplete" attribute and value in the generated input tag. An alternative could be to disable autocomplete behaviors entirely (not sure how).

What is the current behavior?

Chrome will suggest to autofill the md-input generated by the md-datepicker with an email (in my case, but this may vary).

What is the use-case or motivation for changing an existing behavior?

If a user wants to autofill other fields of the form, the datepicker will be populated with wrong data.

Which versions of AngularJS, Material, OS, and browsers are affected?

  • AngularJS: 1.7.9
  • AngularJS Material: 1.1.12
  • OS: Mac OS High Sierra 10.13.6
  • Browsers: Chrome

Is there anything else we should know? Stack Traces, Screenshots, etc.

Nothing relevant

TheManuz avatar Jan 29 '20 17:01 TheManuz

What value would you assign in this case? The autocomplete attribute doesn't have any date-related values other than birth dates.

Do you just want to set autocomplete="off"?

Splaktar avatar Feb 01 '20 01:02 Splaktar

I found in my tests that autocomplete="off" doesn't work anymore. The new (hacky) way is to set autocomplete="new-search".

I've asked to explicitly propagate the parameter on the compiled <input> just to be future proof, in the eventuality that autocomplete="new-search" stop working again with a future update.

TheManuz avatar Feb 02 '20 11:02 TheManuz

OK, I think that it would be reasonable to accept a PR to add a new md-datepicker-autocomplete API for doing this. We're mostly relying on the community to send PRs for enhancements at this time as we're focused on fixing high priority bugs/a11y issues/perf problems only.

Splaktar avatar Feb 14 '20 01:02 Splaktar