dev-infra icon indicating copy to clipboard operation
dev-infra copied to clipboard

fix(shared-docs): extract captured group from heading custom id regexp

Open lacolaco opened this issue 1 year ago • 1 comments

String#match doesn't return captured group for a "global" pattern. To get it, RegExp#exec() is appropriate. The previous test case was passed with a string that converted the entire header to an ID even though the capture failed, so it was fixed to match the custom id exactly.

This PR fixes my fault in #2195

lacolaco avatar Jul 25 '24 01:07 lacolaco

@JeanMeche @josephperrott Sorry for the repeated bother. Could you please take a look at this?

lacolaco avatar Jul 25 '24 01:07 lacolaco

This PR was merged into the repository by commit 722ce5b647ec89797633452dd293e1dbac776ff1.

The changes were merged into the following branches: main

josephperrott avatar Jul 25 '24 13:07 josephperrott

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.