components icon indicating copy to clipboard operation
components copied to clipboard
verified publisher icon angular

fix(dialog): improved handling of scrollable content

Open crisbeto opened this issue 7 years ago • 21 comments

  • Improves the handling of scrollable content inside the mat-dialog-content by using flexbox, rather than a hardcoded max-height, to define the content height. This resolves various issues where the dialog would go out of the screen at certain screen sizes or have multiple scrollbars.
  • Uses flexbox to ensure that the dialog content elements are always at the appropriate size.

Fixes #2481. Fixes #3239. Fixes #6584. Fixes #8493.

crisbeto avatar Jan 04 '18 19:01 crisbeto

Addressed the feedback @jelbourn.

crisbeto avatar Jan 12 '18 18:01 crisbeto

Looking forward to this merge!

dinamix1 avatar Mar 21 '18 16:03 dinamix1

Great work on this PR! I am really looking forward to this enhancement as well. It looks like the only reason it hasn't been merged in yet is because the Travis CI build failed due to server issues. Can someone please re-run the build? Thanks!

pharv avatar Apr 23 '18 23:04 pharv

What are the presubmit failures that are keeping this from being merged? I, too, am having the same scrolling issues with the material dialogs.

Devvox93 avatar Jun 22 '18 12:06 Devvox93

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. Please help to unblock it by resolving these conflicts. Thanks!

ngbot[bot] avatar Jul 11 '18 15:07 ngbot[bot]

This fix will be very helpful. Any updates on the PR?

tammysock avatar Jul 17 '18 18:07 tammysock

Hi, I would really appreciate this fix too, we've been waiting for a year now for this to land (we're eager to take out our own hacks to overcome some issues that this would fix..)

So, any news about this @crisbeto @jelbourn ?

swftvsn avatar Aug 23 '18 07:08 swftvsn

It's blocked until we can resolve this change breaking some things inside Google.

jelbourn avatar Aug 23 '18 15:08 jelbourn

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. Please help to unblock it by resolving these conflicts. Thanks!

ngbot[bot] avatar Sep 19 '18 21:09 ngbot[bot]

Hi @jelbourn is this issue still blocked on your side?

rkrzewski avatar Oct 16 '18 11:10 rkrzewski

Yes

jelbourn avatar Oct 16 '18 16:10 jelbourn

This fixes #13190

josephperrott avatar Nov 01 '18 21:11 josephperrott

@crisbeto is this PR going to happen?

jpike88 avatar Mar 05 '19 06:03 jpike88

This PR would fix major problems I'm having using MatDialog, any updates?

MaximoB avatar May 06 '19 15:05 MaximoB

What is the status of this PR? When will it be completed.

akvaliya avatar Oct 31 '19 09:10 akvaliya

@jelbourn is this still blocked?

charsleysa avatar Jan 09 '20 06:01 charsleysa

Yes- we haven't work on this since the last update. At this point, we'll probably see if we can address this as part of our work on integrating MDC-web into the components.

jelbourn avatar Jan 09 '20 23:01 jelbourn

@jelbourn have you had a chance to find out whether integrating MDC-web into the components will solve the problems that this PR intended to solve?

AlexElin avatar Mar 03 '21 16:03 AlexElin

@crisbeto is this something you've looked at for the mdc dialog?

jelbourn avatar Mar 03 '21 21:03 jelbourn

I haven't looked into the MDC dialog since somebody else implemented it.

crisbeto avatar Mar 03 '21 22:03 crisbeto

@crisbeto Looks like this PR has fallen out of date, can you please rebase the PR.

josephperrott avatar Nov 19 '21 16:11 josephperrott

Hope this PR is not abandoned and will be merged someday

Mikastark avatar Aug 01 '23 14:08 Mikastark