components icon indicating copy to clipboard operation
components copied to clipboard

fix(tabs): preserve scroll position when switching between tabs

Open crisbeto opened this issue 8 years ago • 13 comments

Preserves the scroll position when switching between tabs. Previously it was being reset to 0, because we detach and re-attach the content.

Fixes #6722.

crisbeto avatar Sep 02 '17 16:09 crisbeto

@crisbeto @andrewseguin should we revisit this or close?

jelbourn avatar Jan 24 '18 19:01 jelbourn

I think it's still a valid issue, but I haven't gotten around to finding an Android phone to test the issue that @andrewseguin mentioned.

crisbeto avatar Jan 24 '18 19:01 crisbeto

AFAIK Chrome dev tools should mimic Android Chrome pretty well. Was it not reproducible there?

jelbourn avatar Jan 24 '18 22:01 jelbourn

AFAIK the Chrome dev tools only resize the viewport, simulate touch events and fake the user agent.

crisbeto avatar Jan 26 '18 19:01 crisbeto

@crisbeto Please rebase when you have a chance.

josephperrott avatar Mar 30 '18 18:03 josephperrott

Rebased.

crisbeto avatar Mar 31 '18 08:03 crisbeto

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. Please help to unblock it by resolving these conflicts. Thanks!

ngbot[bot] avatar Jul 11 '18 15:07 ngbot[bot]

Hey @crisbeto - if you don't mind rebasing, we can try to get this pushed in

andrewseguin avatar Feb 14 '19 19:02 andrewseguin

It's good to go now @andrewseguin.

crisbeto avatar Feb 16 '19 09:02 crisbeto

Also, do you mind adding in this example to the Material Examples? We don't currently have a good example of scrolling content in our tabs and it can be used to double-check the functionality

https://stackblitz.com/edit/angular-vtgxfn?file=main.ts

andrewseguin avatar Feb 19 '19 18:02 andrewseguin

Done @andrewseguin.

crisbeto avatar Feb 19 '19 18:02 crisbeto

Any news?

deftomat avatar Apr 10 '19 09:04 deftomat

(revisiting old PRs) Keeping this one open since we still want to land it, but still lower priority than other issues.

jelbourn avatar Jun 13 '19 17:06 jelbourn