angular.js
angular.js copied to clipboard
angular
log usable error on unhandled non error rejections Fixes #15816
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Feature
What is the current behavior? (You can also link to an open issue here) #15816
What is the new behavior (if this is a feature change)? #15816
Does this PR introduce a breaking change? No
Please check if the PR fulfills these requirements
- [ ] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
Other information:
Is this a feature you want? Do you like the implementation?
On 21 Mar 2017 2:24 pm, "George Kalpakas" [email protected] wrote:
We need tests.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/angular/angular.js/pull/15818#issuecomment-288076303, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZQTP1v2Jtito9NC42ZXpIuaV2Nj1H3ks5rn8-CgaJpZM4MeBdk .
I never look at the implementation if there are no tests 😛 If we can have the feature in a consistent way and without hurting working usecases, it is fine (but I am not sure it is possible).
All the extra state should be totally hidden until it hits the unhandled rejection code
On 21 Mar 2017 15:31, "George Kalpakas" [email protected] wrote:
I never look at the implementation if there are no tests 😛 If we can have the feature in a consistent way and without hurting working usecases, it is fine (but I am not sure it is possible).
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/angular/angular.js/pull/15818#issuecomment-288095887, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZQTHL4OVim7SRXO4wvXxz7jzCXL4mNks5rn99EgaJpZM4MeBdk .