angular-update-guide icon indicating copy to clipboard operation
angular-update-guide copied to clipboard

Steps/Translation keys are not unique across versions and features

Open kirjs opened this issue 3 years ago • 0 comments

in the list of recommendations I see multiple steps with the same key, across different versions and features, e.g. with windows enabled or not:

image

In translations this key maps to the actual translation, leading to duplicated translations for different recommendations (e.g. #179). This also leads to inability to properly translate those messages (as you can only have 1 translation for all of those)

I'm not super familiar with how translations are setup in the app, but my recommendation would be for the key names to be based on version and features, e.g.

here instead of just having both keys as update @angular/material image

We can change them to update @angular/material@9 and update @angular/material@9 windows image

This would allow to properly translate those.

Does this sound like a good approach? If yes, i'd be happy to look into this

kirjs avatar Aug 08 '22 10:08 kirjs