ui-map icon indicating copy to clipboard operation
ui-map copied to clipboard

Fix multiple compilations from duplicating items in ng-repeat

Open runxc1 opened this issue 12 years ago • 7 comments

https://github.com/angular-ui/ui-map/issues/12

runxc1 avatar Jun 19 '13 16:06 runxc1

Think you could add a unit test or 2 to show this fixes the bug in question?

ProLoser avatar Jun 21 '13 07:06 ProLoser

Do we need the compile flag & check at all? It seems that simply commenting out lines 73-78 in the original works as expected.

EDIT:

Found that it needs to compile once or else ng-click won't work. Don't need to decorate the infoWindow.open() though; compiling once in the link function seems to suffice. See https://github.com/Valorum/ui-map/commit/327d7ef2fb95e25ebc2b47596319a601cddfd20d

Valorum avatar Jul 23 '13 21:07 Valorum

Can this pull request being merged or the Valorum's one... The issue is still happening

brooly avatar Sep 24 '13 19:09 brooly

This fix works for me, it has stopped the event handlers from multiplying.

conorw avatar May 16 '14 08:05 conorw

+1

sandcastle avatar Jul 03 '14 15:07 sandcastle

@Valorum fix worked fine for me, please accept that

rsantosdev avatar Jul 03 '14 15:07 rsantosdev

Any update on if this will be accepted? - its been open for over a year now.

sandcastle avatar Jul 17 '14 11:07 sandcastle