ui-leaflet-draw icon indicating copy to clipboard operation
ui-leaflet-draw copied to clipboard

Directive to search parent for leaflet directive

Open eugenehuangsg opened this issue 8 years ago • 3 comments

I'm experimenting with separation of concerns using nested components within the leaflet directive. And I was thinking there is no real limitation on why we shouldn't allow ui-leaflet-draw to still work within the nested components. Is this okay?

eugenehuangsg avatar Mar 30 '17 08:03 eugenehuangsg

@nmccready Yes, i absolutely agree that it should work for both parent and on its own element. (Should not break any existing paradigm). It was my oversight that read '^^' wrongly from the documentation. I have since changed it to only '^' and built dist using gulp. Thanks for pointing out the documentation clearly.

This is actually interesting because in reality I think this directive only depends on leaflet directive to get its relative map being loaded .

Yes, i think its very interesting too. So as long as this draw directive can find the leaflet's controller, everything should work as designed.

eugenehuangsg avatar Mar 30 '17 16:03 eugenehuangsg

@nmccready Is this okay?

eugenehuangsg avatar Apr 15 '17 09:04 eugenehuangsg

If we do this then we will need to bump the minor or major. Also from this main leaflets directive's standpoint all the directives share the same scope. So this is a break from the original design. Anyway, neither this or the other project is very active anymore. So I can be swayed either way.

nmccready avatar Aug 04 '17 00:08 nmccready