zen icon indicating copy to clipboard operation
zen copied to clipboard

Add to Scoop

Open sbstn87 opened this issue 1 year ago • 9 comments
trafficstars

Hi,

will it be possible to add Zen to Scoop?

https://scoop.sh/

sbstn87 avatar Dec 06 '23 15:12 sbstn87

I'll look into it.

anfragment avatar Dec 06 '23 16:12 anfragment

@anfragment I'll write the manifest and submit a pull request if you want

kzshantonu avatar Dec 06 '23 19:12 kzshantonu

@anfragment I'll write the manifest and submit a pull request if you want

Feel free to proceed.

anfragment avatar Dec 07 '23 11:12 anfragment

Done! Use the same file names from now on please.

https://github.com/ScoopInstaller/Extras/pull/12428

kzshantonu avatar Dec 07 '23 12:12 kzshantonu

Done! Use the same file names from now on please.

ScoopInstaller/Extras#12428

Awesome! Couple small issues:

  • Zen creates and stores data under user\AppData\Local\Zen. Could you add an uninstall script to clean up the folder?
  • Zen auto-updates itself on every launch, which is probably not how an app installed via a package manager should behave. I'm already working on providing separate builds with self-updates turned off, could you replace the URLs once they're done?

anfragment avatar Dec 07 '23 13:12 anfragment

uninstall script to clean up the folder

This is not recommended because usually scoop users prefer to use the --purge flag if they do want to remove configs. Post-uninstallation scripts run regardless of that flag so wouldn't work. To behave correctly with that flag, config needs to be on the same directory as the executable.

could you replace the URLs once they're done

Sure

kzshantonu avatar Dec 07 '23 14:12 kzshantonu

@kzshantonu

could you replace the URLs once they're done

Sure

The latest release and each subsequent one will now include assets named "Zen_windows_amd64_noselfupdate.zip" and "Zen_windows_arm64_noselfupdate.zip" containing binaries with their self-updates disabled.

This is not recommended because usually scoop users prefer to use the --purge flag if they do want to remove configs. Post-uninstallation scripts run regardless of that flag so wouldn't work. To behave correctly with that flag, config needs to be on the same directory as the executable.

I'm not sure if I can prioritize the implementation of a setting for a custom configuration folder path at the moment.

anfragment avatar Dec 08 '23 17:12 anfragment

will now include assets named "Zen_windows_amd64_noselfupdate.zip" and "Zen_windows_arm64_noselfupdate.zip"

Updated

I'm not sure if I can prioritize the implementation of a setting for a custom configuration folder path at the moment

That's okay

kzshantonu avatar Dec 08 '23 18:12 kzshantonu

Updated

Thanks. I'll close the issue when the pull request gets merged.

anfragment avatar Dec 08 '23 19:12 anfragment