Andy Zhang

Results 651 comments of Andy Zhang

finally I have worked out a [PR ](https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2287) to get rid of expensive call `(Get-Item -Path $Env:mount).Target`

> I am experiencing the same issue. I have between 6 to 16 disks attached on B8ms windows nodes. I modified temporarily the limits on the deamon set of csi-azuredisk-node-win...

> @andyzhangx I assume It is better to uninstall the AKS managed csi-driver and install it myself with the chart to the latest version right? it's fixed in https://github.com/kubernetes-sigs/azuredisk-csi-driver/releases/tag/v1.28.8, we...

this should be fixed by https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2246 in v1.30.1, v1.29.5, what is your csi driver version? @dominiquehunziker

nvm, that looks like k8s yaml config parsing issue

what about this solution? if `tags` parameter only contains a base64 encoded string, it would do base64 decoding first, e.g. if it's `tags: dmFsdWUtMiwgdmFsdWUtMwo=`, the driver would decode as `tags:...

I think we could add a new parameter, e.g. `base64Tags: dmFsdWUtMiwgdmFsdWUtMwo=`, that should work?

@dominiquehunziker what about adding a new parameter `tagValueDelimiter`, by default, it's using comma to delimite, and user could self define the delimiter, I think that's more compatible ```yaml apiVersion: storage.k8s.io/v1...

I think adding a new parameter `tagValueDelimiter` should be more graceful though the above trick may work. we will work on this feature in July, sorry for the delay since...