laravel-js-localization icon indicating copy to clipboard operation
laravel-js-localization copied to clipboard

[feature] default language keys when missing in a split_export_files

Open Cyrille37 opened this issue 6 years ago • 4 comments

Hi and thanks a lot for this great and useful package.

It could be nice to have an option that make generation of split_export_files merging default language keys when they are missing in a language file.

For example with those languages keys in resources/langs :

  • en [default]
    • foo
    • bar
  • fr
    • foo

we could navigate in language "fr" and displaying the "en [default]" value in place of the key path.

Also it make Javascript translation works like the Php Laravel side with a default language value when a language missing a key.

I Hope to be clear enough ... I'm not sure :-)

Cyrille37 avatar Jan 18 '19 09:01 Cyrille37

Interesting point. Thanks for sharing, @Cyrille37!

Anyone else have an opinion on that?

andywer avatar Jan 19 '19 21:01 andywer

I'am glad using this package, And we also finding a solution for this in our project. Really appreciate if you guys can add this ASAP. Thanks

ackalhan avatar Feb 01 '19 12:02 ackalhan

This package is not under active development anymore, at least not by me.

Feel free to submit a PR implementing the feature you need, though. I will handle the PR, we just need some community work here 😉

andywer avatar Feb 02 '19 00:02 andywer

@andywer made a pull with a change check that out thanks. https://github.com/andywer/laravel-js-localization/pull/62

ackalhan avatar Feb 05 '19 15:02 ackalhan