Andrew Craig

Results 97 comments of Andrew Craig

Hi @DonJayamanne, thanks for your notes. > when using the interactive window in Jupyter extension, the code is sent directly to the selected R juoyter kernel. This is how I'm...

Here's the function that sends text to be executed. What I'm imagining is a modification that checks whether the user has set `R: Always Use Jupyter Interactive Window` and if...

I believe this would require VS Code to allow customisation of mouse shortcuts. There's an open feature request (with 1138 upvotes!): https://github.com/microsoft/vscode/issues/3130

If cursor is on third line, sending all four lines to the console would be fine too.

The problem is that the algorithm treats commas the same as operators like '+', so it views lines 2 and 3 as a complete expression. But a comma can only...

The general concept was to send the 'minimum bit of runnable code' to the console. That's why `1` is sent to the console in this example with the cursor on...

Something to consider if changing the existing behaviour is how to handle nesting. Consider the following case: ```r a( b( 1 ) ) ``` If the cursor is on line...

Hi @brianmsm, thank you for the feedback. It does seem like a few people have found the existing behaviour surprising and undesirable. It could be changed but it would need...

@brianmsm Here's the function that handles it: https://github.com/REditorSupport/vscode-R/blob/da579cc17a9485f7a11bf5e75bf6b9c347eca116/src/selection.ts#L161

Changing the behaviour could perhaps be achieved by adding `(` to this line: https://github.com/REditorSupport/vscode-R/blob/da579cc17a9485f7a11bf5e75bf6b9c347eca116/src/lineCache.ts#L73 Then the algorithm would check for a `(` at the end of the previous line in...