gcp-gradle-build-cache
gcp-gradle-build-cache copied to clipboard
Exclude kotlin-stdlib from plugin dependencies
- Closes #51.
- Closes #59.
https://kotlinlang.org/docs/gradle.html#dependency-on-the-standard-library
Run diff gcpbuildcache-1.0.0.module.before gcpbuildcache-1.0.0.module.after:
28,36d27
< "dependencies": [
< {
< "group": "org.jetbrains.kotlin",
< "module": "kotlin-stdlib",
< "version": {
< "requires": "2.0.21"
< }
< }
< ],
109,115d99
< },
< {
< "group": "org.jetbrains.kotlin",
< "module": "kotlin-stdlib",
< "version": {
< "requires": "2.0.21"
< }
kotlin.compilerOptions.apiVersion should also be constrainted, like https://github.com/GradleUp/shadow/blob/d64ef3787ca0298addd7cb4dbd4beb49814b2bee/build.gradle.kts#L23-L24
Is there any blocker to merge this PR?
CC @liutikas
This is not a safe change. We do require kotlin-stdlib to run, so we should be declaring that we use it and we tested it at a specific version.
https://kotlinlang.org/docs/gradle.html#dependency-on-the-standard-library seems to be a dead link
it kind of sounds like the request in the linked issues to go to a lower version to support older versions of Gradle. Is that the goal?
https://kotlinlang.org/docs/gradle-configure-project.html#dependency-on-the-standard-library
This plugin relies on Kotlin and Gradle integrates Kotlin stdlibs, so what we can do is pin the kotlin.languageVersion and omit the plugin's transitive Kotlin version.
it kind of sounds like the request in the linked issues to go to a lower version to support older versions of Gradle. Is that the goal?
Yeah, it is.
https://github.com/androidx/gcp-gradle-build-cache/pull/72 we'll do the following to bring to down to Gradle 8.4