nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

Rewrite all UI tests with the Robot design pattern #401

Open JanFidor opened this issue 3 years ago • 6 comments

All tests have been rewritten with robot design pattern with no changes to the inner logic of the test (the only exception being bookmarks feature -> feed_whenRemovingBookmark_removesBookmark() test. I believe that my change allows for more flexibility with testing multiple bookmark deletions)

JanFidor avatar Nov 06 '22 17:11 JanFidor

Thanks for this PR. Please run

./gradlew --init-script gradle/init.gradle.kts spotlessApply

to fix formatting issues, and also resolve the merge conflicts.

dturner avatar Nov 11 '22 18:11 dturner

Hi! Thanks for the quick script, it definitely saved me a lot of time. I'm terribly grateful for the opportunity to contribute here, unfortunately I might have gotten a little to enthusiastic about it and messed up git history a bit (sorry, I'll make sure not to do that next time) but everything's working and the gradle script throws up no errors.

JanFidor avatar Nov 11 '22 22:11 JanFidor

Waiting for author to update PR

mmoczkowski avatar Nov 15 '22 11:11 mmoczkowski

Just noticed the merge conflict, I'll resolve in 3h max

JanFidor avatar Nov 15 '22 13:11 JanFidor

Resolved the merge conflict

JanFidor avatar Nov 15 '22 15:11 JanFidor

CI checks seem to be failing due to com.google.samples.apps.nowinandroid.ui.NavigationTest -> navigationBar_reselectTab_keepsState test. I've tried a lot of things (including but not limited to clearing my gradle cache) but I can't reproduce it locally, more importantly, my PR didn't change that file, so the CI checks seem to be the problem, could you confirm @mmoczkowski ?

JanFidor avatar Nov 17 '22 19:11 JanFidor